[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code |
Date: |
Mon, 23 Apr 2018 14:52:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
>
>> + /* we will need a new memory slot for kvm and vhost */
>> + if (kvm_enabled() && !kvm_has_free_slot(machine)) {
>> + error_setg(errp, "hypervisor has no free memory slots left");
>> + return;
>> + }
>> + if (!vhost_has_free_slot()) {
>> + error_setg(errp, "a used vhost backend has no free memory slots
>> left");
>> + return;
>> + }
> move these checks to pre_plug time
>
>> +
>> + memory_region_add_subregion(&hpms->mr, addr - hpms->base, mr);
> missing vmstate registration?
Missed this one: To be called by the caller. Important because e.g. for
virtio-pmem we don't want this (I assume :) ).
Thanks!
--
Thanks,
David / dhildenb
- Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface, (continued)
Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface, Pankaj Gupta, 2018/04/22
[Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, David Hildenbrand, 2018/04/20
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code,
David Hildenbrand <=
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, Igor Mammedov, 2018/04/24
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, David Hildenbrand, 2018/04/24
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, Igor Mammedov, 2018/04/24
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, David Hildenbrand, 2018/04/24
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, Pankaj Gupta, 2018/04/25
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, Igor Mammedov, 2018/04/25
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, Pankaj Gupta, 2018/04/25
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, Igor Mammedov, 2018/04/25
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, Pankaj Gupta, 2018/04/26
Re: [Qemu-devel] [PATCH v3 3/3] pc-dimm: factor out address space logic into MemoryDevice code, David Hildenbrand, 2018/04/23