[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 06/33] blockjob: Remove block_job_pause/resume_a
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [RFC PATCH 06/33] blockjob: Remove block_job_pause/resume_all() |
Date: |
Tue, 24 Apr 2018 17:24:48 +0200 |
Commit 81193349 removed the only use of block_job_pause/resume_all(),
which was in bdrv_drain_all(). The functions are now unused and can be
removed.
Signed-off-by: Kevin Wolf <address@hidden>
---
include/block/blockjob_int.h | 14 --------------
blockjob.c | 27 ---------------------------
2 files changed, 41 deletions(-)
diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
index d26115207b..6a3d03ef0f 100644
--- a/include/block/blockjob_int.h
+++ b/include/block/blockjob_int.h
@@ -174,20 +174,6 @@ void block_job_yield(BlockJob *job);
int64_t block_job_ratelimit_get_delay(BlockJob *job, uint64_t n);
/**
- * block_job_pause_all:
- *
- * Asynchronously pause all jobs.
- */
-void block_job_pause_all(void);
-
-/**
- * block_job_resume_all:
- *
- * Resume all block jobs. Must be paired with a preceding block_job_pause_all.
- */
-void block_job_resume_all(void);
-
-/**
* block_job_early_fail:
* @bs: The block device.
*
diff --git a/blockjob.c b/blockjob.c
index 42e34aa704..de64bdba7a 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -1008,19 +1008,6 @@ void *block_job_create(const char *job_id, const
BlockJobDriver *driver,
return job;
}
-void block_job_pause_all(void)
-{
- BlockJob *job = NULL;
- while ((job = block_job_next(job))) {
- AioContext *aio_context = blk_get_aio_context(job->blk);
-
- aio_context_acquire(aio_context);
- block_job_ref(job);
- block_job_pause(job);
- aio_context_release(aio_context);
- }
-}
-
void block_job_early_fail(BlockJob *job)
{
assert(job->status == BLOCK_JOB_STATUS_CREATED);
@@ -1098,20 +1085,6 @@ void coroutine_fn block_job_pause_point(BlockJob *job)
}
}
-void block_job_resume_all(void)
-{
- BlockJob *job, *next;
-
- QLIST_FOREACH_SAFE(job, &block_jobs, job_list, next) {
- AioContext *aio_context = blk_get_aio_context(job->blk);
-
- aio_context_acquire(aio_context);
- block_job_resume(job);
- block_job_unref(job);
- aio_context_release(aio_context);
- }
-}
-
/*
* Conditionally enter a block_job pending a call to fn() while
* under the block_job_lock critical section.
--
2.13.6
- [Qemu-devel] [RFC PATCH 00/33] Generic background jobs, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 04/33] blockjob: Introduce block_job_ratelimit_get_delay(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 03/33] blockjob: Implement block_job_set_speed() centrally, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 02/33] blockjob: Move RateLimit to BlockJob, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 01/33] blockjob: Wrappers for progress counter access, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 06/33] blockjob: Remove block_job_pause/resume_all(),
Kevin Wolf <=
- [Qemu-devel] [RFC PATCH 05/33] blockjob: Add block_job_driver(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 08/33] job: Rename BlockJobType into JobType, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 10/33] job: Add job_delete(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 09/33] job: Add JobDriver.job_type, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 11/33] job: Maintain a list of all jobs, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 15/33] job: Add Job.aio_context, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 07/33] job: Create Job, JobDriver and job_create(), Kevin Wolf, 2018/04/24