Re: [Qemu-devel] [PATCH 2/2] ui: introduce vfio_display_reset

[Zhang, Tina]

> -----Original Message-----
> From: intel-gvt-dev [mailto:address@hidden On
> Behalf Of Gerd Hoffmann
> Sent: Tuesday, April 24, 2018 4:16 PM
> To: Zhang, Tina <address@hidden>
> Cc: address@hidden; address@hidden; qemu-
> address@hidden; address@hidden; Yuan, Hang
> <address@hidden>
> Subject: Re: [PATCH 2/2] ui: introduce vfio_display_reset
> 
>   Hi,
> 
> > After reviewing this patch-set again, I think we might not need the
> > proposed dpy_gfx_switch_surface() any more.  The reason I proposed it
> > was because I thought gfx.ds is changed to the surface related to
> > guest dma-buf framebuffer and we need to switch it with QemuConsole's
> > DisplaySurgface during reset.  But after reviewing the code,
> > vc->gfx.ds is always pointing to the valid QemuConsoles'
> > DisplaySurface. So we don’t need dpy_gfx_switch_surface() to take care
> > of it.
> 
> Good, this is what I expected.
> 
> > > Maybe you just need a full display update after disabling the gl
> > > scanout?
> > Do you still think updating full display is needed?
> 
> It certainly isn't required, gtk wouldn't access the dma-buf any more after
> scanout_disable().
> 
> Without display update the last guest display may remain visible until the 
> guest
> reloads the driver though.  With display update the gtk ui should show the
> (blank) DisplaySurface instead.  So it is more cosmetical.
Indeed. Thanks for the comments. I will send out the next version of this 
patch-set.
Thanks.

BR,
Tina
> 
> cheers,
>   Gerd
> 
> _______________________________________________
> intel-gvt-dev mailing list
> address@hidden
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev