Re: [Qemu-devel] [PATCH v3 03/46] configure: add support for --cross-cc-FOO

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> On 04/24/2018 05:23 AM, Alex Bennée wrote:
>> @@ -675,10 +687,12 @@ case "$cpu" in
>>    i386|i486|i586|i686|i86pc|BePC)
>>      cpu="i386"
>>      supported_cpu="yes"
>> +    cross_cc_i386=gcc
>>    ;;
>>    x86_64|amd64)
>>      cpu="x86_64"
>>      supported_cpu="yes"
>> +    cross_cc_x86_64=gcc
>>    ;;
>>    armv*b|armv*l|arm)
>>      cpu="arm"
>
> Isn't this hunk taken care of in the next patch, where you set these to $cc?
> And if not, surely bare "gcc" isn't correct...

Woops, I'll fix that.

>
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
>
>
> r~


--
Alex Bennée