[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 02/17] replay: disable default snapshot for reco
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH 02/17] replay: disable default snapshot for record/replay |
Date: |
Wed, 25 Apr 2018 15:45:45 +0300 |
User-agent: |
StGit/0.17.1-dirty |
From: Pavel Dovgalyuk <address@hidden>
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
vl.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index fce1fd1..ca4239c 100644
--- a/vl.c
+++ b/vl.c
@@ -3226,7 +3226,13 @@ int main(int argc, char **argv, char **envp)
drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS);
break;
case QEMU_OPTION_snapshot:
- snapshot = 1;
+ {
+ Error *blocker = NULL;
+ snapshot = 1;
+ error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED,
+ "-snapshot");
+ replay_add_blocker(blocker);
+ }
break;
case QEMU_OPTION_numa:
opts = qemu_opts_parse_noisily(qemu_find_opts("numa"),
@@ -4529,7 +4535,7 @@ int main(int argc, char **argv, char **envp)
qapi_free_BlockdevOptions(bdo->bdo);
g_free(bdo);
}
- if (snapshot || replay_mode != REPLAY_MODE_NONE) {
+ if (snapshot) {
qemu_opts_foreach(qemu_find_opts("drive"), drive_enable_snapshot,
NULL, NULL);
}
- [Qemu-devel] [RFC PATCH 00/17] reverse debugging, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 01/17] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 02/17] replay: disable default snapshot for record/replay,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH 03/17] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 04/17] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 06/17] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 05/17] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 07/17] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/25
- [Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/04/25