[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json"
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json" |
Date: |
Wed, 25 Apr 2018 13:54:46 +0100 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Apr 24, 2018 at 06:11:05PM -0500, Eric Blake wrote:
> On 04/24/2018 04:45 PM, Laszlo Ersek wrote:
> > We'll soon need an enumeration type that lists all the softmmu targets
> > that QEMU (the project) supports. Introduce @SysEmuTarget to
> > "common.json".
> >
> > Cc: "Daniel P. Berrange" <address@hidden>
> > Cc: David Gibson <address@hidden>
> > Cc: Eric Blake <address@hidden>
> > Cc: Gerd Hoffmann <address@hidden>
> > Cc: Kashyap Chamarthy <address@hidden>
> > Cc: Markus Armbruster <address@hidden>
> > Cc: Paolo Bonzini <address@hidden>
> > Cc: Thomas Huth <address@hidden>
> > Signed-off-by: Laszlo Ersek <address@hidden>
> > Reviewed-by: Markus Armbruster <address@hidden>
> > Reviewed-by: Kashyap Chamarthy <address@hidden>
> > ---
> >
>
> > +##
> > +{ 'enum' : 'SysEmuTarget',
> > + 'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
> > + 'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64',
> > + 'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc',
> > + 'ppc64', 'ppcemb', 'riscv32', 'riscv64', 's390x', 'sh4',
> > + 'sh4eb', 'sparc', 'sparc64', 'tricore', 'unicore32',
> > + 'x86_64', 'xtensa', 'xtensaeb' ] }
>
> x86_64 doesn't match our typical conventions of preferring '-' over '_';
> also, wikipedia mentions both spellings but under the page name
> 'x86-64'. Is it worth switching that enum constant?
>
> https://en.wikipedia.org/wiki/X86-64
I would not want that - SysEmuTarget is supposed to be correlated with
the qemu-system-$TARGET binary names and we use qemu-system-x86_64
there.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH 1/6] qapi: fill in CpuInfoFast.arch in query-cpus-fast, Laszlo Ersek, 2018/04/24
[Qemu-devel] [PATCH 2/6] qapi: handle the riscv CpuInfoArch in query-cpus-fast, Laszlo Ersek, 2018/04/24