[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected charde
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected chardevs |
Date: |
Wed, 25 Apr 2018 16:37:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 20.04.2018 16:52, Peter Maydell wrote:
> Currently the serial.c realize code has an explicit check that it is not
> connected to a disconnected backend (ie one with a NULL chardev).
> This isn't what we want -- you should be able to create a serial device
> even if it isn't attached to anything. Remove the check.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/char/serial.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index eb72191ee7..2c080c9862 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -923,11 +923,6 @@ static int serial_be_change(void *opaque)
>
> void serial_realize_core(SerialState *s, Error **errp)
> {
> - if (!qemu_chr_fe_backend_connected(&s->chr)) {
> - error_setg(errp, "Can't create serial device, empty char device");
> - return;
> - }
> -
> s->modem_status_poll = timer_new_ns(QEMU_CLOCK_VIRTUAL, (QEMUTimerCB *)
> serial_update_msl, s);
>
> s->fifo_timeout_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, (QEMUTimerCB *)
> fifo_timeout_int, s);
>
Acked-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH 03/13] hw/mips/boston.c: Don't create "null" chardevs for serial devices, (continued)
- [Qemu-devel] [PATCH 03/13] hw/mips/boston.c: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 02/13] hw/arm/fsl-imx*: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected chardevs, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 07/13] Change references to serial_hds[] to serial_hd(), Peter Maydell, 2018/04/20
- Re: [Qemu-devel] [PATCH 00/13] Drop compile time limit on number of serial ports, no-reply, 2018/04/21
- Re: [Qemu-devel] [PATCH 00/13] Drop compile time limit on number of serial ports, Peter Maydell, 2018/04/26