Re: [Qemu-devel] [PULL 01/16] migration: introduce postcopy-blocktime capability

[Eric Blake]

On 04/25/2018 03:03 PM, Dr. David Alan Gilbert (git) wrote:
> From: Alexey Perevalov <address@hidden>
> 
> Right now it could be used on destination side to
> enable vCPU blocktime calculation for postcopy live migration.
> vCPU blocktime - it's time since vCPU thread was put into
> interruptible sleep, till memory page was copied and thread awake.
> 
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Alexey Perevalov <address@hidden>
> Reviewed-by: Juan Quintela <address@hidden>
> Signed-off-by: Juan Quintela <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---

> +++ b/qapi/migration.json
> @@ -354,16 +354,20 @@
>  #
>  # @x-multifd: Use more than one fd for migration (since 2.11)
>  #
> +#
>  # @dirty-bitmaps: If enabled, QEMU will migrate named dirty bitmaps.

Why is the extra blank line added here?  Doesn't hold up the pull
request, but might be worth a trivial followup patch.

>  #                 (since 2.12)
>  #
> +# @postcopy-blocktime: Calculate downtime for postcopy live migration
> +#                     (since 2.13)
> +#
>  # Since: 1.2
>  ##
>  { 'enum': 'MigrationCapability',
>    'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks',
>             'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram',
>             'block', 'return-path', 'pause-before-switchover', 'x-multifd',
> -           'dirty-bitmaps' ] }
> +           'dirty-bitmaps', 'postcopy-blocktime' ] }
>  
>  ##
>  # @MigrationCapabilityStatus:
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature