[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types |
Date: |
Thu, 26 Apr 2018 12:06:51 +0100 |
(expanding the CC to include everyone that get_maintainer suggests)
Ian Jackson writes ("[PATCH 01/16] checkpatch: Add xendevicemodel_handle to the
list of types"):
> This avoids checkpatch misparsing (as statements) long function
> definitions or declarations, which sometimes start with constructs
> like this:
>
> static inline int xendevicemodel_relocate_memory(
> xendevicemodel_handle *dmod, domid_t domid, ...
>
> The type xendevicemodel_handle does not conform to Qemu CODING_STYLE,
> which would suggest CamelCase. However, it is a type defined by the
> Xen Project in xen.git. It would be possible to introduce a typedef
> to allow the qemu code to refer to it by a differently-spelled name,
> but that would obfuscate more than it would clarify.
This patch has been posted in substantially similar form quite a few
times now. Paolo Bonzini understandably suggested that renaming the
variable would be better but that's not within qemu's bailiwick as I
say above.
I think everything else in this series has a review and/or an ack.
So I would like to send a pull request.
Does someone want to review this patch ? Should I drop it and just
let checkpatch complain ? Shold I include it in my pull request
anyway ?
Thanks,
Ian.
- [Qemu-devel] [PATCH v8 00/16] xen: xen-domid-restrict improvements, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 02/16] AccelClass: Introduce accel_setup_post, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid, Ian Jackson, 2018/04/24
- [Qemu-devel] [PATCH 07/16] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/04/24