[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 5/6] iotests: Add new test 214 for max compre
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v6 5/6] iotests: Add new test 214 for max compressed cluster offset |
Date: |
Thu, 26 Apr 2018 14:10:58 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 26 Apr 2018 04:51:28 AM CEST, Eric Blake wrote:
> If you have a capable file system (tmpfs is good, ext4 not so much;
> run ./check with TEST_DIR pointing to a good location so as not
> to skip the test), it's actually possible to create a qcow2 file
> that expands to a sparse 512T image with just over 38M of content.
> The test is not the world's fastest (qemu crawling through 256M
> bits of refcount table to find the next cluster to allocate takes
> several seconds, as does qemu-img check reporting millions of
> leaked clusters); but it DOES catch the problem that the previous
> patch just fixed where writing a compressed cluster to a full
> image ended up overwriting the wrong cluster.
>
> Suggested-by: Max Reitz <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
Nice test :-)
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-devel] [PATCH v6 0/6] minor qcow2 compression improvements, Eric Blake, 2018/04/25
- [Qemu-devel] [PATCH v6 4/6] qcow2: Don't allow overflow during cluster allocation, Eric Blake, 2018/04/25
- [Qemu-devel] [PATCH v6 6/6] qcow2: Avoid memory over-allocation on compressed images, Eric Blake, 2018/04/25
- [Qemu-devel] [PATCH v6 3/6] qcow2: Reduce REFT_OFFSET_MASK, Eric Blake, 2018/04/25
- [Qemu-devel] [PATCH v6 5/6] iotests: Add new test 214 for max compressed cluster offset, Eric Blake, 2018/04/25
- Re: [Qemu-devel] [PATCH v6 5/6] iotests: Add new test 214 for max compressed cluster offset,
Alberto Garcia <=
- [Qemu-devel] [PATCH v6 1/6] qcow2: Prefer byte-based calls into bs->file, Eric Blake, 2018/04/25
- [Qemu-devel] [PATCH v6 2/6] qcow2: Document some maximum size constraints, Eric Blake, 2018/04/25