[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test f
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test for qapi-schema |
Date: |
Fri, 27 Apr 2018 17:11:37 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/27/2018 10:05 AM, Igor Mammedov wrote:
> make sure the QAPISchema can parse allowed-in-preconfig correctly
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> tests/Makefile.include | 1 +
> tests/qapi-schema/allowed-in-preconfig-test.err | 1 +
> tests/qapi-schema/allowed-in-preconfig-test.exit | 1 +
> tests/qapi-schema/allowed-in-preconfig-test.json | 2 ++
> tests/qapi-schema/allowed-in-preconfig-test.out | 0
> tests/qapi-schema/qapi-schema-test.json | 3 +++
> tests/qapi-schema/qapi-schema-test.out | 2 ++
> tests/test-qmp-cmds.c | 4 ++++
Aha. I'd squash this with patch 6, since it supplies the additional
tests I was asking about there. (They were separate on the OOB series
more because of the time crunch of getting it in before rc0; but now
that we aren't under a crunch, I'd rather just have one patch for all
new tests).
> 8 files changed, 14 insertions(+)
> create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.err
> create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.exit
> create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.json
> create mode 100644 tests/qapi-schema/allowed-in-preconfig-test.out
>
If you like my bikeshedding for a shorter 'allow-preconfig' name, don't
forget to rename the files as well as their contents.
> +++ b/tests/qapi-schema/qapi-schema-test.json
> @@ -142,6 +142,9 @@
> # Smoke test on Out-Of-Band
> { 'command': 'an-oob-command', 'allow-oob': true }
>
> +# test allowed-in-preconfig flag
> +{ 'command': 'allowed-in-preconfig-test', 'allowed-in-preconfig': true }
Why not just have a single command that sets both allow-oob and
allowed-in-preconfig on the same command? Of course, rename it to
something other than 'an-oob-command', if you merge things into one command.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 00/11] enable numa configuration before machine_init() from QMP, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 06/11] tests: let qapi-schema tests detect allowed-in-preconfig, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 05/11] qapi: introduce new cmd option "allowed-in-preconfig", Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test for qapi-schema, Igor Mammedov, 2018/04/27
- Re: [Qemu-devel] [PATCH v6 07/11] tests: add allowed-in-preconfig-test for qapi-schema,
Eric Blake <=
- [Qemu-devel] [PATCH v6 11/11] tests: functional tests for QMP command set-numa-node, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 01/11] numa: postpone options post-processing till machine_run_board_init(), Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 08/11] tests: extend qmp test with preconfig checks, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 04/11] hmp: disable monitor in preconfig state, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 10/11] qmp: add set-numa-node command, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 09/11] qmp: permit query-hotpluggable-cpus in preconfig state, Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 02/11] numa: split out NumaOptions parsing into set_numa_options(), Igor Mammedov, 2018/04/27
- [Qemu-devel] [PATCH v6 03/11] cli: add --preconfig option, Igor Mammedov, 2018/04/27