[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v2 14/19] translator: fix breakpoint processing
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v2 14/19] translator: fix breakpoint processing |
Date: |
Sat, 28 Apr 2018 15:37:48 +0300 |
User-agent: |
StGit/0.17.1-dirty |
QEMU cannot pass through the breakpoints when 'si' command is used
in remote gdb. This patch disables inserting the breakpoints
when we are already single stepping though the gdb remote protocol.
This patch also fixes icount calculation for the blocks that include
breakpoints - instruction with breakpoint is not executed and shouldn't
be used in icount calculation.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
accel/tcg/translator.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
index 23c6602..3c7a035 100644
--- a/accel/tcg/translator.c
+++ b/accel/tcg/translator.c
@@ -35,6 +35,7 @@ void translator_loop(const TranslatorOps *ops,
DisasContextBase *db,
CPUState *cpu, TranslationBlock *tb)
{
int max_insns;
+ int bp_insn = 0;
/* Initialize DisasContext */
db->tb = tb;
@@ -73,11 +74,13 @@ void translator_loop(const TranslatorOps *ops,
DisasContextBase *db,
tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */
/* Pass breakpoint hits to target for further processing */
- if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) {
+ if (!db->singlestep_enabled
+ && unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) {
CPUBreakpoint *bp;
QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) {
if (bp->pc == db->pc_next) {
if (ops->breakpoint_check(db, cpu, bp)) {
+ bp_insn = 1;
break;
}
}
@@ -119,7 +122,7 @@ void translator_loop(const TranslatorOps *ops,
DisasContextBase *db,
/* Emit code to exit the TB, as indicated by db->is_jmp. */
ops->tb_stop(db, cpu);
- gen_tb_end(db->tb, db->num_insns);
+ gen_tb_end(db->tb, db->num_insns - bp_insn);
/* The disas_log hook may use these values rather than recompute. */
db->tb->size = db->pc_next - db->pc_first;
- [Qemu-devel] [RFC PATCH v2 03/19] replay: update docs for record/replay with block devices, (continued)
- [Qemu-devel] [RFC PATCH v2 03/19] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 08/19] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 06/19] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 05/19] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 07/19] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 09/19] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 10/19] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 11/19] replay: flush events when exitting, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 12/19] timer: remove replay clock probe in deadline calculation, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 13/19] replay: refine replay-time module, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 14/19] translator: fix breakpoint processing,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v2 15/19] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 16/19] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 17/19] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 18/19] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 19/19] replay: allow loading any snapshots before recording, Pavel Dovgalyuk, 2018/04/28
- Re: [Qemu-devel] [RFC PATCH v2 00/19] reverse debugging, Ciro Santilli, 2018/04/30