Re: [Qemu-devel] [RFC PATCH 02/12] tests/tcg/tricore: Add build infrastructure

[Bastian Koppelmann]

Hi Phil,

On 05/02/2018 02:41 AM, Philippe Mathieu-Daudé wrote:
> Hi Bastian,
> 
> On 05/01/2018 11:22 AM, Bastian Koppelmann wrote:
>> this includes the Makefile and linker script to build all the tests.
>>
>> Signed-off-by: Bastian Koppelmann <address@hidden>
>> ---
>>  tests/tcg/tricore/Makefile | 30 +++++++++++++++++++++++
>>  tests/tcg/tricore/link.ld  | 60 
>> ++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 90 insertions(+)
>>  create mode 100644 tests/tcg/tricore/Makefile
>>  create mode 100644 tests/tcg/tricore/link.ld
>>
>> diff --git a/tests/tcg/tricore/Makefile b/tests/tcg/tricore/Makefile
>> new file mode 100644
>> index 0000000000..8c168d1062
>> --- /dev/null
>> +++ b/tests/tcg/tricore/Makefile
>> @@ -0,0 +1,30 @@
>> +AS := tricore-as
>> +LD := tricore-ld
>> +HOST_CC = gcc
>> +
>> +LDFLAGS = -Tlink.ld
>> +ASFLAGS =
>> +
>> +SIM = ../../../tricore-softmmu/qemu-system-tricore
>> +SIMFLAGS = -M tricore_testboard -nographic -kernel
> 
> I applied this on upstream QEMU (26bd8d98c4b32).
> 
> I suppose you are doing in-tree build, since this doesn't work with> 
> out-of-tree builds (see the $SIM relative path).

Ooops, this is mostly copied from tests/tcg/xtensa :)

> 
> I then get:
> 
> tricore-softmmu/qemu-system-tricore -M tricore_testboard -nographic
> -kests/tcg/tricore/test_muls.tst -d in_asm
> QEMU 2.12.50 monitor - type 'help' for more information
> (qemu) QEMU 2.12.50 monitor - type 'help' for more information
> (qemu) IN:
> 0x80000000:  qemu-system-tricore: function cpu_get_phys_page_attrs_debug
> not implemented, aborting

This is odd. I'll try to reproduce it.

[...]
> http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg00151.html
> (which you can build with 'make docker-image-debian-tricore-cross', I
> didn't try to merge your series over Alex's tcg-testing one)

Thanks for creating this docker image, you helped me a great deal :)

[...]
>> +
>> +all: build
>> +
>> +%.pS: %.S
>> +    $(HOST_CC) -E -o $@ $<
>> +
>> +%.o: %.pS
>> +    $(AS) $(ASFLAGS) -o $@ $<
>> +
>> +%.tst: %.o link.ld
>> +    $(LD) $(LDFLAGS) $< -o $@
> 
> Those rules did not work for me:

I assume make uses the built-in rules. Can you try $ make --no-builtin-rules?

Cheers,
Bastian