qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with prep


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 26/67] cpu: replace command line flags with preprocessor
Date: Thu, 3 May 2018 15:08:32 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of cpu.h depending on the target.

Replace with per-target ifdefs which are easier to understand.

Signed-off-by: Michael S. Tsirkin <address@hidden>
---
  include/cpu.h | 2 ++
  1 file changed, 2 insertions(+)
  create mode 100644 include/cpu.h

diff --git a/include/cpu.h b/include/cpu.h
new file mode 100644
index 0000000..b18f163
--- /dev/null
+++ b/include/cpu.h
@@ -0,0 +1,2 @@
+#include "target-dir.h"
+#include TARGET_DIR(cpu.h)

Out-of-order patch? I don't see target-dir.h created anywhere earlier in this series.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]