Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one

[Eric Blake]

On 05/03/2018 03:29 PM, Michael S. Tsirkin wrote:

> > There are a few .c files exempt from including osdep.h, but in general,
> > those files should probably also not be including anything from include/.
>
> Here's a list from a quick grep.
> Most of them probably get osdep.h indirectly.
>
>
> +contrib/libvhost-user/libvhost-user.c

contrib may or may not be exempt; but it's not in the whitelist.

> +hw/rdma/rdma_utils.c

Probably a bug; looks like a recently added file.

> +libuser/trace.c

Huh? I don't see this file in git.

> +target/mips/translate_init.c
> +target/ppc/mfrom_table.c

Probably bugs.

> +target/ppc/translate/dfp-impl.inc.c

This, and all other .inc.c, are indeed picking it up indirectly (by the 
master .c that is including these secondary .c), so they are exempt. 
They are whitelisted by the script via the shell case statement.

> +target/s390x/gen-features.c

Possibly a bug.

> +tests/multiboot/libc.c
> +tests/multiboot/mmap.c
> +tests/multiboot/modules.c

Exempt, per the XDIRREGEX in scripts/clean-includes

> lots of files under tests/tcg

Also exempt.

> +tests/test-qapi-event.c

Huh? That starts with #include "qemu/osdep.h".  But it's not a file 
under version control.  In fact, it's stale leftovers (it used to be 
generated by that name, but now we generate tests/test-qapi-events.c.

> +tests/test-qapi-types.c
> +tests/test-qapi-visit.c
> +tests/test-qmp-introspect.c
> +tests/test-qmp-marshal.c

Again, how are you flagging these generated files?

> +ui/keycodemapdb/tests/stdc.c

Exempt, since it's in a submodule.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org