[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/10] qapi: deprecate CpuInfoFast.arch
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 10/10] qapi: deprecate CpuInfoFast.arch |
Date: |
Fri, 4 May 2018 10:04:54 +0200 |
From: Laszlo Ersek <address@hidden>
The TARGET_BASE_ARCH values from "configure" don't all map to the
@CpuInfoArch enum constants; in particular "s390x" from the former does
not match @s390 in the latter. Clients are known to rely on the @s390
constant specifically, so we can't change it silently. Instead, deprecate
the @address@hidden member (in favor of @address@hidden) using the
regular deprecation process.
(No deprecation reminder is added to sysemu_target_to_cpuinfo_arch(): once
@address@hidden is removed, the assignment expression that calls
sysemu_target_to_cpuinfo_arch() from qmp_query_cpus_fast() will have to
disappear; in turn the static function left without callers will also
break the build, thus it'll have to go.)
Cc: "Daniel P. Berrange" <address@hidden>
Cc: Eric Blake <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Laszlo Ersek <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
qapi/misc.json | 8 ++++----
qemu-doc.texi | 5 +++++
2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/qapi/misc.json b/qapi/misc.json
index fa4eec7b6b..f5988cc0b5 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -558,11 +558,11 @@
# @props: properties describing to which node/socket/core/thread
# virtual CPU belongs to, provided if supported by board
#
-# @arch: base architecture of the cpu
+# @arch: base architecture of the cpu; deprecated since 2.13.0 in favor
+# of @target
#
-# @target: the QEMU system emulation target, which is more specific than
-# @arch and determines which additional fields will be listed
-# (since 2.13)
+# @target: the QEMU system emulation target, which determines which
+# additional fields will be listed (since 2.13)
#
# Since: 2.12
#
diff --git a/qemu-doc.texi b/qemu-doc.texi
index 5813d27615..0ed0f19e6b 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2949,6 +2949,11 @@ from qcow2 images.
The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command.
address@hidden query-cpus-fast "arch" output member (since 2.13.0)
+
+The ``arch'' output member of the ``query-cpus-fast'' command is
+replaced by the ``target'' output member.
+
@section System emulator devices
@subsection ivshmem (since 2.6.0)
--
2.13.6
- [Qemu-devel] [PULL 00/10] QAPI patches for 2018-05-04, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 07/10] qapi: add SysEmuTarget to "common.json", Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 08/10] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 03/10] qobject: use a QObjectBase_ struct, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 06/10] qapi: fill in CpuInfoFast.arch in query-cpus-fast, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 02/10] qobject: Ensure base is at offset 0, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 09/10] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 05/10] qobject: Modify qobject_ref() to return obj, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 01/10] qobject: Use qobject_to() instead of type cast, Markus Armbruster, 2018/05/04
- [Qemu-devel] [PULL 10/10] qapi: deprecate CpuInfoFast.arch,
Markus Armbruster <=
- [Qemu-devel] [PULL 04/10] qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF, Markus Armbruster, 2018/05/04
- Re: [Qemu-devel] [PULL 00/10] QAPI patches for 2018-05-04, Peter Maydell, 2018/05/04