[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/67] block: use local path for local headers
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH 01/67] block: use local path for local headers |
Date: |
Fri, 4 May 2018 10:32:12 +0100 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, May 03, 2018 at 10:50:20PM +0300, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
This commit message is wrong. Directory paths work by design, since
we explicitly add -I$SRCDIR to the include path.
If we want to drop -I$SRCDIR, lets be clear about that being the
reason, rather than pretending this is an accident.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH 04/67] s390x: drop an unused include, (continued)
- [Qemu-devel] [PATCH 03/67] hppa: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 06/67] trace: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 07/67] display: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 09/67] ioapic: fix up includes, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 01/67] block: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- Re: [Qemu-devel] [PATCH 01/67] block: use local path for local headers,
Daniel P . Berrangé <=
- [Qemu-devel] [PATCH 10/67] e1000e: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 08/67] ide: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 11/67] rocker: drop an unused include, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 12/67] ppc: use local path for local headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 13/67] vhost-scsi: drop an unused include, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 14/67] sd: fix up include, Michael S. Tsirkin, 2018/05/03