[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version and warn about old APIs |
|
Date: |
Tue, 8 May 2018 17:14:01 +0100 |
|
User-agent: |
Mutt/1.9.3 (2018-01-21) |
On Tue, May 08, 2018 at 06:02:55PM +0200, Paolo Bonzini wrote:
> On 08/05/2018 17:19, Daniel P. Berrangé wrote:
> > Ok, that change looks fine with me assuming it passes your build tests.
> > In fact that is what I had done in an earlier version.
> >
> > Regards,
> > Daniel
>
> Actually there is a use of g_strv_contains in tests/test-qga.c. It is
> guarded by GLIB_CHECK_VERSION(2, 44, 0) but the right fix should be to
> include the compatibility function instead.
>
> For now I am dropping this patch.
Ok, I'll have a look at that, and re-post an updated patch later. There
are a few other uses of GLIB_CHECK_VERSION to be investigated too I see.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42, no-reply, 2018/05/04
Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42, no-reply, 2018/05/04
Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42, Olaf Hering, 2018/05/04
Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42, Daniel P . Berrangé, 2018/05/04
Re: [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42, Paolo Bonzini, 2018/05/04