Re: [Qemu-devel] [PATCH 5/5] linux-user: add sparc/sparc64 specific errno

[Laurent Vivier]

Le 08/05/2018 à 22:22, Max Filippov a écrit :
> On Tue, May 8, 2018 at 12:40 PM, Laurent Vivier <address@hidden> wrote:
>> Copied from linux/arch/sparc/include/uapi/asm/errno.h
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>>  linux-user/sparc/target_syscall.h   | 203 
>> ++++++++++++++++++++++++++++++++++++
>>  linux-user/sparc64/target_syscall.h | 203 
>> ++++++++++++++++++++++++++++++++++++
>>  2 files changed, 406 insertions(+)
> 
> The changes are coming from single file, why duplicating them?
> Could they go into e.g. linux-user/sparc/target_errno.h, and get
> #included by both linux-user/sparc/target_syscall.h and
> linux-user/sparc64/target_syscall.h?
> 

Yes, I was also thinking at something like that.

I did like that because in QEMU sparc and sparc64 use two different
directories whereas in linux they use the same one. Duplication seems to
be the rule...

I will do as you suggest in v2 of the series.

Thanks,
Laurent