[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] m68k: fix floatx80_mod() (Coverity CID1390568)
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] m68k: fix floatx80_mod() (Coverity CID1390568) |
|
Date: |
Wed, 9 May 2018 07:04:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 08.05.2018 22:39, Laurent Vivier wrote:
> Update the variable checked by the loop condition (expDiff).
> Backport the update from Previous.
>
> Fixes: 591596b77a ("target/m68k: add fmod/frem")
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> target/m68k/softfloat.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c
> index e41b07d042..d093997219 100644
> --- a/target/m68k/softfloat.c
> +++ b/target/m68k/softfloat.c
> @@ -103,6 +103,7 @@ floatx80 floatx80_mod(floatx80 a, floatx80 b,
> float_status *status)
> mul64To128(bSig, qTemp, &term0, &term1);
> sub128(aSig0, aSig1, term0, term1, &aSig0, &aSig1);
> shortShift128Left(aSig0, aSig1, 62, &aSig0, &aSig1);
> + expDiff -= 62;
> }
> expDiff += 64;
> if (0 < expDiff) {
Reviewed-by: Thomas Huth <address@hidden>