[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 36/36] target-microblaze: Use tcg_gen_movcond
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 36/36] target-microblaze: Use tcg_gen_movcond in eval_cond_jmp |
Date: |
Wed, 9 May 2018 14:21:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/08/2018 10:31 AM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Cleanup eval_cond_jmp to use tcg_gen_movcond_i64().
> No functional change.
>
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Edgar E. Iglesias <address@hidden>
> ---
> target/microblaze/translate.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 256acce876..a4f6b307d3 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1167,12 +1167,9 @@ static inline void eval_cc(DisasContext *dc, unsigned
> int cc,
>
> static void eval_cond_jmp(DisasContext *dc, TCGv_i64 pc_true, TCGv_i64
> pc_false)
> {
> - TCGLabel *l1 = gen_new_label();
> - /* Conditional jmp. */
> - tcg_gen_mov_i64(cpu_SR[SR_PC], pc_false);
> - tcg_gen_brcondi_i64(TCG_COND_EQ, env_btaken, 0, l1);
> - tcg_gen_mov_i64(cpu_SR[SR_PC], pc_true);
> - gen_set_label(l1);
> + tcg_gen_movcond_i64(TCG_COND_NE, cpu_SR[SR_PC],
> + env_btaken, tcg_const_i64(0),
> + pc_true, pc_false);
Ah. I would probably just extend env_btaken here instead of the previous patch.
r~
- Re: [Qemu-devel] [PATCH v2 30/36] target-microblaze: Simplify address computation using tcg_gen_addi_i32(), (continued)
- [Qemu-devel] [PATCH v2 33/36] target-microblaze: Remove argument b in eval_cc(), Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 32/36] target-microblaze: Use table based condition-codes conversion, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 31/36] target-microblaze: mmu: Cleanup debug log messages, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 35/36] target-microblaze: Convert env_btarget to i64, Edgar E. Iglesias, 2018/05/08
- [Qemu-devel] [PATCH v2 36/36] target-microblaze: Use tcg_gen_movcond in eval_cond_jmp, Edgar E. Iglesias, 2018/05/08
- Re: [Qemu-devel] [PATCH v2 36/36] target-microblaze: Use tcg_gen_movcond in eval_cond_jmp,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 34/36] target-microblaze: Convert env_btaken to i64, Edgar E. Iglesias, 2018/05/08
- Message not available