[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/4] monitor: protect mon->fds with mon_lock
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 2/4] monitor: protect mon->fds with mon_lock |
|
Date: |
Thu, 10 May 2018 11:11:58 +0100 |
|
User-agent: |
Mutt/1.9.3 (2018-01-21) |
On Wed, May 09, 2018 at 12:17:32PM +0800, Peter Xu wrote:
> mon->fds were protected by BQL. Now protect it by mon_lock so that it
> can even be used in monitor iothread.
Only monitor_get_fd() can safely be called from the monitor iothread
(oob).
The other functions call close(2), which may block, and therefore aren't
allowed in oob code.
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v5 0/4] monitor: let Monitor be thread safe, Peter Xu, 2018/05/09
- [Qemu-devel] [PATCH v5 1/4] monitor: rename out_lock to mon_lock, Peter Xu, 2018/05/09
- [Qemu-devel] [PATCH v5 2/4] monitor: protect mon->fds with mon_lock, Peter Xu, 2018/05/09
- [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Peter Xu, 2018/05/09
- Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Stefan Hajnoczi, 2018/05/10
- Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Markus Armbruster, 2018/05/17
- Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Peter Xu, 2018/05/18
- Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Markus Armbruster, 2018/05/23
- Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Peter Xu, 2018/05/23
- Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Markus Armbruster, 2018/05/23
- Re: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs, Peter Xu, 2018/05/24
[Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/09