[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] linux-user: move ppc socket.h definitions t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] linux-user: move ppc socket.h definitions to ppc/sockbits.h |
Date: |
Fri, 11 May 2018 13:12:20 +0100 |
On 10 May 2018 at 23:26, Laurent Vivier <address@hidden> wrote:
> No code change.
>
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> --- a/linux-user/socket.h
> +++ b/linux-user/socket.h
> @@ -1,6 +1,6 @@
>
> #if defined(TARGET_MIPS) || defined(TARGET_HPPA) || defined(TARGET_ALPHA) ||
> \
> - defined(TARGET_SPARC)
> + defined(TARGET_SPARC) || defined(TARGET_PPC)
> #include "sockbits.h"
> #else
Follow-on cleanup: rather than having this long list of target ifdefs,
we should just have every target supply a sockbits.h (perhaps deferring
to a generic set of values the way that lots of archs use the asm-generic
versions).
thanks
-- PMM
- [Qemu-devel] [PATCH 0/5] linux-user: move socket.h definitions to CPU directories, Laurent Vivier, 2018/05/10
- [Qemu-devel] [PATCH 4/5] linux-user: move ppc socket.h definitions to ppc/sockbits.h, Laurent Vivier, 2018/05/10
- [Qemu-devel] [PATCH 5/5] linux-user: copy sparc/sockbits.h definitions from linux, Laurent Vivier, 2018/05/10
- [Qemu-devel] [PATCH 3/5] linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h, Laurent Vivier, 2018/05/10
- [Qemu-devel] [PATCH 2/5] linux-user: move alpha socket.h definitions to alpha/sockbits.h, Laurent Vivier, 2018/05/10
- [Qemu-devel] [PATCH 1/5] linux-user: move mips socket.h definitions to mips/sockbits.h, Laurent Vivier, 2018/05/10
- Re: [Qemu-devel] [PATCH 0/5] linux-user: move socket.h definitions to CPU directories, no-reply, 2018/05/10