[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps |
Date: |
Fri, 11 May 2018 22:24:11 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
b396d1ea56 target/m68k: Merge disas_m68k_insn into m68k_tr_translate_insn
1454f7ac75 target/m68k: Improve ending TB at page boundaries
180209d486 target/m68k: Convert to TranslatorOps
838e40004e target/m68k: Convert to DisasContextBase
88f0d5dff1 target/m68k: Rename DISAS_UPDATE and gen_lookup_tb
78920794cd target/m68k: Use lookup_and_goto_tb for DISAS_JUMP
0ae1c99c4a target/m68k: Remove DISAS_JUMP_NEXT as unused
127bfcf989 target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN
836179eaad target/m68k: Use DISAS_NORETURN for exceptions
=== OUTPUT BEGIN ===
Checking PATCH 1/9: target/m68k: Use DISAS_NORETURN for exceptions...
Checking PATCH 2/9: target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN...
Checking PATCH 3/9: target/m68k: Remove DISAS_JUMP_NEXT as unused...
Checking PATCH 4/9: target/m68k: Use lookup_and_goto_tb for DISAS_JUMP...
Checking PATCH 5/9: target/m68k: Rename DISAS_UPDATE and gen_lookup_tb...
Checking PATCH 6/9: target/m68k: Convert to DisasContextBase...
ERROR: space required before the open parenthesis '('
#559: FILE: target/m68k/translate.c:6134:
+ switch(dc->base.is_jmp) {
total: 1 errors, 0 warnings, 494 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/9: target/m68k: Convert to TranslatorOps...
Checking PATCH 8/9: target/m68k: Improve ending TB at page boundaries...
Checking PATCH 9/9: target/m68k: Merge disas_m68k_insn into
m68k_tr_translate_insn...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 3/9] target/m68k: Remove DISAS_JUMP_NEXT as unused, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 1/9] target/m68k: Use DISAS_NORETURN for exceptions, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 5/9] target/m68k: Rename DISAS_UPDATE and gen_lookup_tb, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 4/9] target/m68k: Use lookup_and_goto_tb for DISAS_JUMP, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 2/9] target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 8/9] target/m68k: Improve ending TB at page boundaries, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 7/9] target/m68k: Convert to TranslatorOps, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 6/9] target/m68k: Convert to DisasContextBase, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 9/9] target/m68k: Merge disas_m68k_insn into m68k_tr_translate_insn, Richard Henderson, 2018/05/12
- Re: [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps,
no-reply <=
- Re: [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps, Laurent Vivier, 2018/05/13