[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0 |
Date: |
Mon, 14 May 2018 12:16:22 +0200 |
On Fri, 11 May 2018 21:59:43 -0700
Richard Henderson <address@hidden> wrote:
> The warning is
>
> target/s390x/misc_helper.c:209:21: error: suggest
> braces around initialization of subobject [-Werror,-Wmissing-braces]
> SysIB sysib = { 0 };
> ^
> {}
>
> While the original code is correct, and technically exactly correct
> as per ISO C89, both GCC and Clang support plain empty set of braces
> as an extension.
>
> Cc: Alexander Graf <address@hidden>
> Cc: David Hildenbrand <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/s390x/misc_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
> index e0b23c1fd1..1f834f35ef 100644
> --- a/target/s390x/misc_helper.c
> +++ b/target/s390x/misc_helper.c
> @@ -206,7 +206,7 @@ uint32_t HELPER(stsi)(CPUS390XState *env, uint64_t a0,
> uint64_t r0, uint64_t r1)
> const MachineState *ms = MACHINE(qdev_get_machine());
> uint16_t total_cpus = 0, conf_cpus = 0, reserved_cpus = 0;
> S390CPU *cpu = s390_env_get_cpu(env);
> - SysIB sysib = { 0 };
> + SysIB sysib = { };
> int i, cc = 0;
>
> if ((r0 & STSI_R0_FC_MASK) > STSI_R0_FC_LEVEL_3) {
Thanks, applied.
- [Qemu-devel] [PATCH 0/9] target/m68k: Convert to TranslatorOps, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 1/9] target/m68k: Use DISAS_NORETURN for exceptions, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.0, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 2/9] target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 3/9] target/m68k: Remove DISAS_JUMP_NEXT as unused, Richard Henderson, 2018/05/12
- [Qemu-devel] [PATCH 4/9] target/m68k: Use lookup_and_goto_tb for DISAS_JUMP, Richard Henderson, 2018/05/12