[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/27] fpu/softfloat: Move softfloat-speciali
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/27] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition |
Date: |
Mon, 14 May 2018 11:23:47 +0100 |
On 12 May 2018 at 01:42, Richard Henderson <address@hidden> wrote:
> We want to be able to specialize on the canonical representation.
>
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> fpu/softfloat.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index bc0f52fa54..353893aaea 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -95,16 +95,6 @@ this code that are retained.
>
> *----------------------------------------------------------------------------*/
> #include "fpu/softfloat-macros.h"
>
> -/*----------------------------------------------------------------------------
> -| Functions and definitions to determine: (1) whether tininess for underflow
> -| is detected before or after rounding by default, (2) what (if anything)
> -| happens when exceptions are raised, (3) how signaling NaNs are
> distinguished
> -| from quiet NaNs, (4) the default generated quiet NaNs, and (5) how NaNs
> -| are propagated from function inputs to output. These details are target-
> -| specific.
> -*----------------------------------------------------------------------------*/
> -#include "softfloat-specialize.h"
> -
>
> /*----------------------------------------------------------------------------
> | Returns the fraction bits of the half-precision floating-point value `a'.
>
> *----------------------------------------------------------------------------*/
> @@ -247,6 +237,16 @@ typedef struct {
> uint64_t roundeven_mask;
> } FloatFmt;
>
> +/*----------------------------------------------------------------------------
> +| Functions and definitions to determine: (1) whether tininess for underflow
> +| is detected before or after rounding by default, (2) what (if anything)
> +| happens when exceptions are raised, (3) how signaling NaNs are
> distinguished
> +| from quiet NaNs, (4) the default generated quiet NaNs, and (5) how NaNs
> +| are propagated from function inputs to output. These details are target-
> +| specific.
> +*----------------------------------------------------------------------------*/
> +#include "softfloat-specialize.h"
> +
> /* Expand fields based on the size of exponent and fraction */
> #define FLOAT_PARAMS(E, F) \
> .exp_size = E, \
> --
> 2.17.0
>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v2 00/27] softfloat patch roundup, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 01/27] fpu/softfloat: int_to_float ensure r fully initialised, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 02/27] fpu/softfloat: Don't set Invalid for float-to-int(MAXINT), Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 03/27] fpu/softfloat: Merge NO_SIGNALING_NANS definitions, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 05/27] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition, Richard Henderson, 2018/05/11
- Re: [Qemu-devel] [PATCH v2 05/27] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 06/27] fpu/softfloat: Canonicalize NaN fraction, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 04/27] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 07/27] fpu/softfloat: Introduce parts_is_snan_frac, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 08/27] fpu/softfloat: Replace float_class_dnan with parts_default_nan, Richard Henderson, 2018/05/11
- [Qemu-devel] [PATCH v2 09/27] fpu/softfloat: Replace float_class_msnan with parts_silence_nan, Richard Henderson, 2018/05/11