[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] gdbstub: Use qemu_set_cloexe
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] gdbstub: Use qemu_set_cloexec() |
Date: |
Mon, 14 May 2018 15:57:09 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/14/2018 02:30 PM, Peter Maydell wrote:
> Use the utility routine qemu_set_cloexec() rather than
> manually calling fcntl(). This lets us drop the #ifndef _WIN32
> guards and also means Coverity doesn't complain that we're
> ignoring the fcntl error return (CID 1005665, CID 1005667).
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> gdbstub.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 3c3807358c..cc7626c790 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1818,9 +1818,7 @@ static void gdb_accept(void)
> perror("accept");
> return;
> } else if (fd >= 0) {
> -#ifndef _WIN32
> - fcntl(fd, F_SETFD, FD_CLOEXEC);
> -#endif
> + qemu_set_cloexec(fd);
> break;
> }
> }
> @@ -1847,9 +1845,7 @@ static int gdbserver_open(int port)
> perror("socket");
> return -1;
> }
> -#ifndef _WIN32
> - fcntl(fd, F_SETFD, FD_CLOEXEC);
> -#endif
> + qemu_set_cloexec(fd);
>
> socket_set_fast_reuse(fd);
>
>