Re: [Qemu-devel] [PATCH 37/42] job: Move progress fields to Job

[Max Reitz]

On 2018-05-09 18:26, Kevin Wolf wrote:
> BlockJob has fields .offset and .len, which are actually misnomers today
> because they are no longer tied to block device sizes, but just progress
> counters. As such they make a lot of sense in generic Jobs.
> 
> This patch moves the fields to Job and renames them to .progress_current
> and .progress_total to describe their function better.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  include/block/blockjob.h | 25 -------------------------
>  include/qemu/job.h       | 27 +++++++++++++++++++++++++++
>  block/backup.c           |  8 ++++----
>  block/commit.c           |  4 ++--
>  block/mirror.c           |  4 ++--
>  block/stream.c           |  4 ++--
>  blockjob.c               | 26 ++++++++------------------
>  job.c                    | 10 ++++++++++
>  qemu-img.c               |  8 ++++++--
>  9 files changed, 61 insertions(+), 55 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature