[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] bochs-display: add pcie support
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] bochs-display: add pcie support |
Date: |
Fri, 18 May 2018 17:13:27 +0200 |
Hi
On Thu, May 17, 2018 at 11:25 AM, Gerd Hoffmann <address@hidden> wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
Could you explain where the 0x80 offset comes from?
> hw/display/bochs-display.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
> index 9ea6f798f4..23dbf57b8f 100644
> --- a/hw/display/bochs-display.c
> +++ b/hw/display/bochs-display.c
> @@ -254,6 +254,7 @@ static void bochs_display_realize(PCIDevice *dev, Error
> **errp)
> {
> BochsDisplayState *s = BOCHS_DISPLAY(dev);
> Object *obj = OBJECT(dev);
> + int ret;
>
> s->con = graphic_console_init(DEVICE(dev), 0, &bochs_display_gfx_ops, s);
>
> @@ -280,6 +281,12 @@ static void bochs_display_realize(PCIDevice *dev, Error
> **errp)
> pci_register_bar(&s->pci, 0, PCI_BASE_ADDRESS_MEM_PREFETCH, &s->vram);
> pci_register_bar(&s->pci, 2, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mmio);
>
> + if (pci_bus_is_express(pci_get_bus(dev))) {
> + dev->cap_present |= QEMU_PCI_CAP_EXPRESS;
> + ret = pcie_endpoint_cap_init(dev, 0x80);
> + assert(ret > 0);
> + }
> +
> memory_region_set_log(&s->vram, true, DIRTY_MEMORY_VGA);
> }
>
> @@ -341,6 +348,7 @@ static const TypeInfo bochs_display_type_info = {
> .instance_init = bochs_display_init,
> .class_init = bochs_display_class_init,
> .interfaces = (InterfaceInfo[]) {
> + { INTERFACE_PCIE_DEVICE },
> { INTERFACE_CONVENTIONAL_PCI_DEVICE },
> { },
> },
> --
> 2.9.3
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 0/4] display: add new bochs-display device, Gerd Hoffmann, 2018/05/17
- [Qemu-devel] [PATCH 3/4] bochs-display: add dirty tracking support, Gerd Hoffmann, 2018/05/17
- [Qemu-devel] [PATCH 4/4] bochs-display: add pcie support, Gerd Hoffmann, 2018/05/17
- Re: [Qemu-devel] [PATCH 4/4] bochs-display: add pcie support,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 1/4] vga: move bochs vbe defines to header file, Gerd Hoffmann, 2018/05/17
- [Qemu-devel] [PATCH 2/4] display: add new bochs-display device, Gerd Hoffmann, 2018/05/17
- Re: [Qemu-devel] [PATCH 0/4] display: add new bochs-display device, no-reply, 2018/05/17