qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb: update docs


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] usb: update docs
Date: Fri, 25 May 2018 15:43:03 +0200
User-agent: NeoMutt/20180512

> > diff --git a/docs/usb2.txt b/docs/usb2.txt
> > index 09df45b5b1..1b0e62d187 100644
> > --- a/docs/usb2.txt
> > +++ b/docs/usb2.txt
> > @@ -1,6 +1,26 @@
> >  
> > -USB 2.0 Quick Start
> > -===================
> > +USB Quick Start
> 
> Would you like to renamed the file from usb2.txt to usb.txt, too?

Good question.  At least I link to qemu cgit now and then when refering
to qemu documentation.  Renaming the file would break the links ...

> > +===============
> > +
> > +xhci controller support
> > +-----------------------
> > +
> > +Qemu has xhci host adapter support.  The xhci hardware design is much
> > +more virtualization-friendly when compared to ehci and uhci, thus xhci
> > +emulation uses less resources (especially cpu).  So if your guest
> > +supports xhci (which should be the case for any operating system
> > +released in recent years) I recommend using it:
> 
> I'm afraid "recent years" won't age gracefully.  Perhaps "after 2011 or
> so"?

Makes sense.

> > @@ -47,29 +67,15 @@ specifies the first port the controller should attach 
> > to, which is
>    Companion controller support
>    ----------------------------
> 
>    Companion controller support has been added recently.  The operational
> 
> For a value of "recently" :)  Rephrase the first sentence?

Well, to be exact pretty much all ehci/uhci text could use a major
rework.  Left that for another day ...

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]