qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/6] scripts/update-linux-headers: Handle __alig


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/6] scripts/update-linux-headers: Handle __aligned_u64
Date: Fri, 25 May 2018 15:59:09 +0100

On 25 May 2018 at 15:55, Richard Henderson <address@hidden> wrote:
> On 05/25/2018 06:27 AM, Peter Maydell wrote:
>> We'll currently replace any 'u64' with a 'uint64_t' including when
>> it's embedded in an '__aligned_u64', creating a '__aligned_uint64_t'
>> which doesn't exist. We need to instead expand out the kernel's
>> definition of __aligned_u64:
>>    #define __aligned_u64 __u64 __attribute__((aligned(8)))
>> before we convert the __u64 to uint64_t.
>
> Wow.  I did not believe that would work.  I expected that you'd need to define
> a typedef, or somehow sort the attribute after the identifier to which it 
> applies.

In the kernel it's a #define, not a typedef, so logically if the
kernel compiles then doing the textual-substitution here with sed
must also work...

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]