qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 15/20] migration: use local path for local he


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers
Date: Fri, 25 May 2018 23:57:46 +0300

On Fri, May 25, 2018 at 08:27:03PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
> > When pulling in headers that are in the same directory as C file (as
> > opposed to one in include/), we should use its relative path, without a
> > directory. Directory based path works more or less by accident.
> 
> I don't agree with the comment that they work by accident,

Oh I removed this from most commit messages but somehow this one managed
to sneek in.  I agree, will drop this sentence.

> it is
> "by-design".  But if you want to change the design, I agree with
> removing "$ROOT" from the default include path.
> 
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> 
> Reviewed-by: Juan Quintela <address@hidden>
> 
> Later, Juan.

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]