[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/20] migration: use local path for local he
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers |
Date: |
Fri, 25 May 2018 23:57:46 +0300 |
On Fri, May 25, 2018 at 08:27:03PM +0200, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
> > When pulling in headers that are in the same directory as C file (as
> > opposed to one in include/), we should use its relative path, without a
> > directory. Directory based path works more or less by accident.
>
> I don't agree with the comment that they work by accident,
Oh I removed this from most commit messages but somehow this one managed
to sneek in. I agree, will drop this sentence.
> it is
> "by-design". But if you want to change the design, I agree with
> removing "$ROOT" from the default include path.
>
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> Reviewed-by: Juan Quintela <address@hidden>
>
> Later, Juan.
Thanks!
- Re: [Qemu-devel] [PATCH v2 13/20] sd: fix up include, (continued)
- [Qemu-devel] [PATCH v2 14/20] usb: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 16/20] colo: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 17/20] qga: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 15/20] migration: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 18/20] trace: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 19/20] ui: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 20/20] arch_init: sort architectures, Michael S. Tsirkin, 2018/05/25
- Re: [Qemu-devel] [PATCH v2 00/20] include cleanups, Eric Blake, 2018/05/25