[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/20] trace: use local path for local header
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/20] trace: use local path for local headers |
Date: |
Sat, 26 May 2018 00:49:56 +0300 |
On Fri, May 25, 2018 at 06:29:29PM -0300, Philippe Mathieu-Daudé wrote:
> On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> > When pulling in headers that are in the same directory as C file (as
> > opposed to one in include/), we should use its relative path, without a
> > directory.
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > Tested-by: Philippe Mathieu-Daudé <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > Tested-by: Philippe Mathieu-Daudé <address@hidden>
>
> This reminds me of this project:
>
> https://github.com/noidontdig/gitdown
>
> gitdown is a script which moderates your git
> committing activity based on your blood alcohol
> content (BAC).
>
> :P
Oh I have a script that attaches signatures, and it does not check for
duplicates.
I started rewriting it using git interpret-trailers but Junio asked me
to rework interpret-trailers first and I didn't bother yet.
> > ---
> > trace/control.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/trace/control.h b/trace/control.h
> > index 1903e22..eb65c8e 100644
> > --- a/trace/control.h
> > +++ b/trace/control.h
> > @@ -267,6 +267,6 @@ char *trace_opt_parse(const char *optarg);
> > uint32_t trace_get_vcpu_event_count(void);
> >
> >
> > -#include "trace/control-internal.h"
> > +#include "control-internal.h"
> >
> > #endif /* TRACE__CONTROL_H */
> >
- [Qemu-devel] [PATCH v2 02/20] crypto: use local path for local headers, (continued)
- [Qemu-devel] [PATCH v2 02/20] crypto: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 03/20] hppa: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 04/20] migration: drop an unused include, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 01/20] block: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 05/20] trace: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 09/20] e1000e: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 06/20] display: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 07/20] ide: use local path for local headers, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 10/20] rocker: drop an unused include, Michael S. Tsirkin, 2018/05/25
- [Qemu-devel] [PATCH v2 11/20] ppc: use local path for local headers, Michael S. Tsirkin, 2018/05/25