[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machi
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP |
Date: |
Mon, 28 May 2018 11:40:45 +0200 |
On Thu, 24 May 2018 17:42:03 +0200
Markus Armbruster <address@hidden> wrote:
> Eduardo Habkost <address@hidden> writes:
>
> > I'm queueing this version (including v8 of patches 5-7) on
> > numa-next.
> >
> > Markus, Daniel: you were the people I remember expressing some
> > concerns about the new preconfig mechanism. Do you have any
> > objections to this version?
>
> My gut's reaction to preconfig is as nauseous as ever. It adds
> complexity we wouldn't want or need with sanely structured program
> startup. It might still be the best we can do, and something we need to
> do. You have to take on technical debt sometimes. To know for sure
> this is the case here, we'd have to explore alternatives more seriously.
> Like repaying some of the existing technical debt around there. Sadly,
> I lack the time to take on such a project.
Usually I do quite a bit of re-factoring to reduce our technical debt,
so while working on enabling VM start with libvirt using only --preconfig
(without -S) I most likely will have to improve code around VM creation.
[...]
- Re: [Qemu-devel] [PATCH v7 11/11] tests: functional tests for QMP command set-numa-node, (continued)
[Qemu-devel] [PATCH v8 11/11] tests: functional tests for QMP command set-numa-node, Igor Mammedov, 2018/05/17
[Qemu-devel] [PATCH v7 08/11] tests: extend qmp test with preconfig checks, Igor Mammedov, 2018/05/04
Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP, Eduardo Habkost, 2018/05/16
Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP, Igor Mammedov, 2018/05/30