[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGA
From: |
linzhecheng |
Subject: |
Re: [Qemu-devel] [PATCH] socket: dont't free msgfds if error equals EAGAIN |
Date: |
Tue, 29 May 2018 08:20:13 +0000 |
CC'ing Daniel P. Berrangé , Peter Xu, Marc-André Lureau, Eric Blake, Gonglei
> -----邮件原件-----
> 发件人: linzhecheng
> 发送时间: 2018年5月29日 10:53
> 收件人: address@hidden
> 抄送: address@hidden; wangxin (U) <address@hidden>;
> linzhecheng <address@hidden>
> 主题: [PATCH] socket: dont't free msgfds if error equals EAGAIN
>
> Signed-off-by: linzhecheng <address@hidden>
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c index
> 159e69c3b1..17519ec589 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -134,8 +134,8 @@ static int tcp_chr_write(Chardev *chr, const uint8_t
> *buf, int len)
> s->write_msgfds,
> s->write_msgfds_num);
>
> - /* free the written msgfds, no matter what */
> - if (s->write_msgfds_num) {
> + /* free the written msgfds in any cases other than errno==EAGAIN */
> + if (EAGAIN != errno && s->write_msgfds_num) {
> g_free(s->write_msgfds);
> s->write_msgfds = 0;
> s->write_msgfds_num = 0;
> --
> 2.12.2.windows.2
>