[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/14] qemu-iotests: Rewrite 212 for blockdev-cr
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH 12/14] qemu-iotests: Rewrite 212 for blockdev-create job |
Date: |
Tue, 29 May 2018 15:21:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-05-25 18:33, Kevin Wolf wrote:
> This rewrites the test case 212 to work with the new x-blockdev-create
> job rather than the old synchronous version of the command.
>
> All of the test cases stay the same as before, but in order to be able
> to implement proper job handling, the test case is rewritten in Python.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/212 | 483
> +++++++++++++++++----------------------------
> tests/qemu-iotests/212.out | 181 ++++++++++-------
> tests/qemu-iotests/group | 2 +-
> 3 files changed, 290 insertions(+), 376 deletions(-)
>
> diff --git a/tests/qemu-iotests/212 b/tests/qemu-iotests/212
> index e5a1ba77ce..5ac4947b82 100755
> --- a/tests/qemu-iotests/212
> +++ b/tests/qemu-iotests/212
[...]
> +import iotests
> +from iotests import imgfmt
> +
> +iotests.verify_image_format(supported_fmts=['parallels'])
> +iotests.verify_protocol(supported=['file'])
> +
> +def blockdev_create(vm, options):
> + result = vm.qmp_log('x-blockdev-create', job_id='job0', options=options)
> +
> + if 'return' in result:
> + assert result['return'] == {}
> + vm.run_job('job0')
> + iotests.log("")
> +
> +with iotests.FilePath('t.vdi') as disk_path, \
't.vdi', are you sure about that? ;-)
(You thought I wouldn't read the boiler plate anymore, didn't you? Ha!)
With that fixed:
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [Qemu-block] [PATCH 10/14] qemu-iotests: Rewrite 210 for blockdev-create job, (continued)
- [Qemu-devel] [PATCH 08/14] qemu-iotests: Rewrite 206 for blockdev-create job, Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 09/14] qemu-iotests: Rewrite 207 for blockdev-create job, Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 11/14] qemu-iotests: Rewrite 211 for blockdev-create job, Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 12/14] qemu-iotests: Rewrite 212 for blockdev-create job, Kevin Wolf, 2018/05/25
- Re: [Qemu-devel] [PATCH 12/14] qemu-iotests: Rewrite 212 for blockdev-create job,
Max Reitz <=
- [Qemu-devel] [PATCH 13/14] qemu-iotests: Rewrite 213 for blockdev-create job, Kevin Wolf, 2018/05/25
- [Qemu-devel] [PATCH 14/14] block/create: Mark blockdev-create stable, Kevin Wolf, 2018/05/25
- Re: [Qemu-devel] [PATCH 00/14] block: Make blockdev-create a job and stable API, no-reply, 2018/05/25
- Re: [Qemu-devel] [PATCH 00/14] block: Make blockdev-create a job and stable API, Eric Blake, 2018/05/25