[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/16] qemu-iotests: iotests.py helper for no
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/16] qemu-iotests: iotests.py helper for non-file protocols |
Date: |
Wed, 30 May 2018 00:33:33 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, May 29, 2018 at 10:39:03PM +0200, Kevin Wolf wrote:
> This adds two helper functions that are useful for test cases that make
> use of a non-file protocol (specifically ssh).
>
> Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 8b612cb891..bc8f404ac2 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -303,6 +303,13 @@ def file_path(*names):
>
> return paths[0] if len(paths) == 1 else paths
>
> +def remote_filename(path):
> + if imgproto == 'file':
> + return path
> + elif imgproto == 'ssh':
> + return "ssh://127.0.0.1%s" % (path)
> + else:
> + raise Exception("Protocol %s not supported" % (imgproto))
>
> class VM(qtest.QEMUQtestMachine):
> '''A QEMU VM'''
> @@ -601,6 +608,16 @@ def verify_image_format(supported_fmts=[],
> unsupported_fmts=[]):
> if not_sup or (imgfmt in unsupported_fmts):
> notrun('not suitable for this image format: %s' % imgfmt)
>
> +def verify_protocol(supported=[], unsupported=[]):
> + assert not (supported and unsupported)
> +
> + if 'generic' in supported:
> + return
> +
> + not_sup = supported and (imgproto not in supported)
> + if not_sup or (imgproto in unsupported):
> + notrun('not suitable for this protocol: %s' % imgproto)
> +
> def verify_platform(supported_oses=['linux']):
> if True not in [sys.platform.startswith(x) for x in supported_oses]:
> notrun('not suitable for this OS: %s' % sys.platform)
> --
> 2.13.6
>
- Re: [Qemu-devel] [PATCH v2 05/16] qemu-iotests: Add VM.get_qmp_events_filtered(), (continued)
- [Qemu-devel] [PATCH v2 07/16] qemu-iotests: Add iotests.img_info_log(), Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 08/16] qemu-iotests: Add VM.run_job(), Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 06/16] qemu-iotests: Add VM.qmp_log(), Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 09/16] qemu-iotests: iotests.py helper for non-file protocols, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 11/16] qemu-iotests: Rewrite 207 for blockdev-create job, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 10/16] qemu-iotests: Rewrite 206 for blockdev-create job, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 13/16] qemu-iotests: Rewrite 211 for blockdev-create job, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 12/16] qemu-iotests: Rewrite 210 for blockdev-create job, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 14/16] qemu-iotests: Rewrite 212 for blockdev-create job, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 15/16] qemu-iotests: Rewrite 213 for blockdev-create job, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 16/16] block/create: Mark blockdev-create stable, Kevin Wolf, 2018/05/29