[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 03/16] job: Add error message for failing job
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 03/16] job: Add error message for failing jobs |
Date: |
Wed, 30 May 2018 11:48:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-05-29 22:38, Kevin Wolf wrote:
> So far we relied on job->ret and strerror() to produce an error message
> for failed jobs. Not surprisingly, this tends to result in completely
> useless messages.
>
> This adds a Job.error field that can contain an error string for a
> failing job, and a parameter to job_completed() that sets the field. As
> a default, if NULL is passed, we continue to use strerror(job->ret).
>
> All existing callers are changed to pass NULL. They can be improved in
> separate patches.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> include/qemu/job.h | 7 ++++++-
> block/backup.c | 2 +-
> block/commit.c | 2 +-
> block/mirror.c | 2 +-
> block/stream.c | 2 +-
> job-qmp.c | 9 ++-------
> job.c | 16 ++++++++++++++--
> tests/test-bdrv-drain.c | 2 +-
> tests/test-blockjob-txn.c | 2 +-
> tests/test-blockjob.c | 2 +-
> 10 files changed, 29 insertions(+), 17 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/16] block: Make blockdev-create a job and stable API, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 01/16] vdi: Fix vdi_co_do_create() return value, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 02/16] vhdx: Fix vhdx_co_create() return value, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 03/16] job: Add error message for failing jobs, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 04/16] block/create: Make x-blockdev-create a job, Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 05/16] qemu-iotests: Add VM.get_qmp_events_filtered(), Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 07/16] qemu-iotests: Add iotests.img_info_log(), Kevin Wolf, 2018/05/29
- [Qemu-devel] [PATCH v2 08/16] qemu-iotests: Add VM.run_job(), Kevin Wolf, 2018/05/29