Re: [Qemu-devel] [RFC 0/3] nRF51 SoC: Add UART support

[Stefan Hajnoczi]

On Tue, May 29, 2018 at 11:57:47PM -0300, Philippe Mathieu-Daudé wrote:
> Hi Julia,
> 
> On 05/29/2018 07:03 PM, Julia Suvorova via Qemu-devel wrote:
> > This series adds basic support for the nRF51 SoC UART, that used in
> > BBC Micro:bit board, and QTest for it.
> > 
> > Based-on: <address@hidden>
> > 
> > Julia Suvorova (3):
> >   hw/arm/nrf51_soc: Fix compilation and memory regions
> 
> Since Joel's series isn't merged, you can simply take his patches, fix
> them, and include them in your following series.  Usually you keep his
> Signed-off-by line, add a comment with your changes, then add your
> S-o-b, such:
> 
>     [PATCH ...] hw/arm: Add Nordic Semiconductor nRF51 SoC
> 
>     The nRF51 is a Cortex-M0 microcontroller with an on-board radio module,
>     plus other common ARM SoC peripherals.
> 
>     This defines a basic model of the CPU and memory, with no peripherals
>     implemented at this stage.
> 
>     Signed-off-by: Joel Stanley <address@hidden>
>     [Julia: Fixed BBC Micro:bit board ROM/RAM size, added FICR defines]
>     Signed-off-by: Julia Suvorova <address@hidden>

I think Joel will send another revision of his series.  It would make
sense for him to squash in this patch.

Stefan

signature.asc
Description: PGP signature