[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip th
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 2/2] arm_gicv3_kvm: kvm_dist_get/put: skip the registers banked by GICR |
|
Date: |
Thu, 31 May 2018 15:56:30 +0100 |
On 31 May 2018 at 15:36, Shannon Zhao <address@hidden> wrote:
>
>
> 2018-05-31 21:50 GMT+08:00 Peter Maydell <address@hidden>:
>> Shouldn't we be adding the same thing to clroffset that we add to offset ?
>>
>> Yeah, right. It should like this
>
> clroffset += (GIC_INTERNAL * 1) / 8;
>
> I don't remember why I didn't write this way. Anyway, Could you please fix
> this when you apply this patch or I send a new version?
It's probably easiest if you resend; you have Eric's comment
typos to fix too.
thanks
-- PMM