Re: [Qemu-devel] [PULL 0/9] slirp updates

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 0/9] slirp updates

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
100c703503 slirp/ncsi: add checksum support
41dba64dbb slirp/ncsi: add a "Get Parameters" response
b0eef29e1d slirp/ncsi: fix "Get Version ID" payload length
9704af1c8c slirp: Send window updates to guest after window was closed
0829b29dd1 net/slirp: Convert atoi to qemu_strtoi to allow error checking
b25abd1163 slirp/debug: Print IP addresses in human readable form
b333e33553 slirp: disable Nagle in ingoing connections
b5523b84a3 slirp: disable Nagle in outgoing connections
9ecad88828 slirp: Add domainname option to slirp's DHCP server

=== OUTPUT BEGIN ===
Checking PATCH 1/9: slirp: Add domainname option to slirp's DHCP server...
Checking PATCH 2/9: slirp: disable Nagle in outgoing connections...
Checking PATCH 3/9: slirp: disable Nagle in ingoing connections...
ERROR: code indent should never use tabs
#24: FILE: slirp/socket.c:757:
+^Iopt = 1;$

ERROR: code indent should never use tabs
#25: FILE: slirp/socket.c:758:
+^Iqemu_setsockopt(s, IPPROTO_TCP, TCP_NODELAY, &opt, sizeof(int));$

total: 2 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/9: slirp/debug: Print IP addresses in human readable form...
ERROR: code indent should never use tabs
#41: FILE: slirp/socket.c:704:
+^IDEBUG_ARG("haddr = %s", inet_ntoa((struct in_addr){.s_addr = haddr}));$

ERROR: code indent should never use tabs
#44: FILE: slirp/socket.c:706:
+^IDEBUG_ARG("laddr = %s", inet_ntoa((struct in_addr){.s_addr = laddr}));$

total: 2 errors, 0 warnings, 27 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/9: net/slirp: Convert atoi to qemu_strtoi to allow error 
checking...
Checking PATCH 6/9: slirp: Send window updates to guest after window was 
closed...
Checking PATCH 7/9: slirp/ncsi: fix "Get Version ID" payload length...
Checking PATCH 8/9: slirp/ncsi: add a "Get Parameters" response...
Checking PATCH 9/9: slirp/ncsi: add checksum support...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden