[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition |
Date: |
Thu, 31 May 2018 20:00:34 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/30/2018 08:43 PM, John Snow wrote:
> Commit d759c951f changed the main thread lock release/reacquisition,
> and in so doing apparently jostled loose a race condition in the AHCI
> code.
>
> Patch 2 should be sufficient to fix this, and patches 1 and 3 are just
> little trivial fixes.
>
> This might be sufficient to fix the bug as reported at
> https://bugs.launchpad.net/qemu/+bug/1769189
> but the nature of the timing changes make it difficult to confirm,
> so I am posting this patchset for the reporters to help test.
>
> John Snow (3):
> ahci: trim signatures on raise/lower
> ahci: fix PxCI register race
> ahci: don't schedule unnecessary BH
>
> hw/ide/ahci.c | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
Thanks for the testing and reviews, everyone!
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
- Re: [Qemu-devel] [PATCH 2/3] ahci: fix PxCI register race, (continued)