qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 1/5] block: Add blklogwrites
Date: Fri, 1 Jun 2018 10:44:55 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/01/2018 10:15 AM, Ari Sundholm wrote:
Thank you.

I'll try to get a new, more proper version of the patchset out for review/comments next week. Sorry for the sloppiness in this first version!

Looking forward to it, even if, as Stefan pointed out, we can already do everything by use of the existing quorum driver and a custom NBD server.

And don't worry about the patch not being perfect the first time - that's just a typical part of the review process. Although unintended on my end, I know that my reviews can be perceived as coming across rather negatively, especially when I don't always remember to also express my appreciation for the efforts you've already put into writing a patch. The community is always better when we remember to treat newcomers (and long-time contributors) nicely, regardless of the outcome of the patch review process; and the reason we review things is so that however sloppy a first draft was, the final product is a lot better!

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]