[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V8 08/17] ram/COLO: Record the dirty pages that SVM
From: |
Zhang Chen |
Subject: |
[Qemu-devel] [PATCH V8 08/17] ram/COLO: Record the dirty pages that SVM received |
Date: |
Sun, 3 Jun 2018 13:05:37 +0800 |
We record the address of the dirty pages that received,
it will help flushing pages that cached into SVM.
Here, it is a trick, we record dirty pages by re-using migration
dirty bitmap. In the later patch, we will start the dirty log
for SVM, just like migration, in this way, we can record both
the dirty pages caused by PVM and SVM, we only flush those dirty
pages from RAM cache while do checkpoint.
Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
---
migration/ram.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
index 2bcd70659f..dd86eeba87 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2831,6 +2831,15 @@ static inline void
*colo_cache_from_block_offset(RAMBlock *block,
__func__, block->idstr);
return NULL;
}
+
+ /*
+ * During colo checkpoint, we need bitmap of these migrated pages.
+ * It help us to decide which pages in ram cache should be flushed
+ * into VM's RAM later.
+ */
+ if (!test_and_set_bit(offset >> TARGET_PAGE_BITS, block->bmap)) {
+ ram_state->migration_dirty_pages++;
+ }
return block->colo_cache + offset;
}
@@ -3061,6 +3070,24 @@ int colo_init_ram_cache(void)
memcpy(block->colo_cache, block->host, block->used_length);
}
rcu_read_unlock();
+ /*
+ * Record the dirty pages that sent by PVM, we use this dirty bitmap
together
+ * with to decide which page in cache should be flushed into SVM's RAM. Here
+ * we use the same name 'ram_bitmap' as for migration.
+ */
+ if (ram_bytes_total()) {
+ RAMBlock *block;
+
+ QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
+ unsigned long pages = block->max_length >> TARGET_PAGE_BITS;
+
+ block->bmap = bitmap_new(pages);
+ bitmap_set(block->bmap, 0, pages);
+ }
+ }
+ ram_state = g_new0(RAMState, 1);
+ ram_state->migration_dirty_pages = 0;
+
return 0;
out_locked:
@@ -3080,6 +3107,10 @@ void colo_release_ram_cache(void)
{
RAMBlock *block;
+ QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
+ g_free(block->bmap);
+ block->bmap = NULL;
+ }
rcu_read_lock();
QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
if (block->colo_cache) {
@@ -3088,6 +3119,8 @@ void colo_release_ram_cache(void)
}
}
rcu_read_unlock();
+ g_free(ram_state);
+ ram_state = NULL;
}
/**
--
2.17.GIT
- [Qemu-devel] [PATCH V8 02/17] colo-compare: implement the process of checkpoint, (continued)
- [Qemu-devel] [PATCH V8 02/17] colo-compare: implement the process of checkpoint, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 03/17] colo-compare: use notifier to notify packets comparing result, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 04/17] COLO: integrate colo compare with colo frame, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 05/17] COLO: Add block replication into colo process, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 06/17] COLO: Remove colo_state migration struct, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 07/17] COLO: Load dirty pages into SVM's RAM cache firstly, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 08/17] ram/COLO: Record the dirty pages that SVM received,
Zhang Chen <=
- [Qemu-devel] [PATCH V8 09/17] COLO: Flush memory data from ram cache, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 10/17] qmp event: Add COLO_EXIT event to notify users while exited COLO, Zhang Chen, 2018/06/03
- [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status, Zhang Chen, 2018/06/03
- Re: [Qemu-devel] [PATCH V8 11/17] qapi: Add new command to query colo status, Markus Armbruster, 2018/06/07