[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/6] ide: push end_transfer_func out of start_tr
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/6] ide: push end_transfer_func out of start_transfer callback, rename callback |
|
Date: |
Mon, 4 Jun 2018 17:48:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 02/06/2018 02:24, John Snow wrote:
>> - if (s->bus->dma->ops->start_transfer) {
>> - s->bus->dma->ops->start_transfer(s->bus->dma);
>> + if (!s->bus->dma->ops->pio_transfer) {
>> + s->end_transfer_func = end_transfer_func;
>> + return;
>> }
>> + s->bus->dma->ops->pio_transfer(s->bus->dma);
>> + end_transfer_func(s);
> Does not setting s->end_transfer_func mess with some of our dumb hacks
> in e.g. ide_restart_bh or ide_is_pio_out?
No, ide_is_pio_out is not used by AHCI and ide_restart_bh looks at the
flags passed to ide_handle_rw_error.
Thanks,
Paolo