Re: [Qemu-devel] [PATCH 07/33] linux-user: Propagate goto fail to return

[Laurent Vivier]

Le 01/06/2018 à 09:30, Richard Henderson a écrit :
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  linux-user/syscall.c | 62 ++++++++++++++++----------------------------
>  1 file changed, 23 insertions(+), 39 deletions(-)
> 

> @@ -9951,18 +9947,15 @@ static abi_long do_syscall1(void *cpu_env, int num, 
> abi_long arg1,
>              case TARGET_SYSLOG_ACTION_READ_CLEAR:    /* Read/clear msgs */
>              case TARGET_SYSLOG_ACTION_READ_ALL:      /* Read last messages */
>                  {
> -                    ret = -TARGET_EINVAL;
>                      if (len < 0) {
> -                        goto fail;
> +                        return -TARGET_EINVAL;
>                      }
> -                    ret = 0;
>                      if (len == 0) {
> -                        return ret;
> +                        return 0;

I think you should do this change in '[PATCH 02/33] linux-user: Relax
single exit from "break"'

Reviewed-by: Laurent Vivier <address@hidden>