Re: [Qemu-devel] [RFC PATCH v2 1/7] tcg: add headers for non-target helpers

[Pavel Dovgalyuk]

> From: Thomas Huth [mailto:address@hidden
> On 05.06.2018 12:39, Pavel Dovgalyuk wrote:
> > From: Pavel Dovgalyuk <address@hidden>
> >
> > This patch adds functions and headers for adding the helpers from
> > the modules other than the target translators.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> > ---
> >  include/exec/helper-register.h |   53 
> > ++++++++++++++++++++++++++++++++++++++++
> >  tcg/tcg.c                      |   12 +++++++++
> >  tcg/tcg.h                      |    3 ++
> >  3 files changed, 68 insertions(+)
> >  create mode 100644 include/exec/helper-register.h
> >
> > diff --git a/include/exec/helper-register.h b/include/exec/helper-register.h
> > new file mode 100644
> > index 0000000..aeface9
> > --- /dev/null
> > +++ b/include/exec/helper-register.h
> > @@ -0,0 +1,53 @@
> > +#ifndef HELPER_REGISTER_H
> > +#define HELPER_REGISTER_H
> > +
> > +#include "exec/helper-head.h"
> > +
> > +/* Need one more level of indirection before stringification
> > +   to get all the macros expanded first.  */
> > +#define str(s) #s
> 
> Could you use tostring() from include/qemu/compiler.h instead?


Thanks, fixed.

BTW, this was a copy-paste from helper-tcg.h

Pavel Dovgalyuk