[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h |
Date: |
Thu, 7 Jun 2018 10:44:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06.06.2018 19:32, Daniel P. Berrangé wrote:
> Code must only ever include glib.h indirectly via the glib-compat.h
> header file, because we will need some macros set before glib.h is
> pulled in. Adding extra includes of glib.h will (soon) cause compile
> failures such as:
>
> In file included from /home/berrange/src/virt/qemu/include/qemu/osdep.h:107,
> from
> /home/berrange/src/virt/qemu/include/qemu/iova-tree.h:26,
> from util/iova-tree.c:13:
> /home/berrange/src/virt/qemu/include/glib-compat.h:22: error:
> "GLIB_VERSION_MIN_REQUIRED" redefined [-Werror]
> #define GLIB_VERSION_MIN_REQUIRED GLIB_VERSION_2_40
>
> In file included from /usr/include/glib-2.0/glib/gtypes.h:34,
> from /usr/include/glib-2.0/glib/galloca.h:32,
> from /usr/include/glib-2.0/glib.h:30,
> from util/iova-tree.c:12:
> /usr/include/glib-2.0/glib/gversionmacros.h:237: note: this is the location
> of the previous definition
> # define GLIB_VERSION_MIN_REQUIRED (GLIB_VERSION_CUR_STABLE)
In case you respin this series, should the order of patch 2 and 3 be
swapped? ... so that we keep the tree bisectable?
Thomas
- Re: [Qemu-devel] [PATCH v2 2/3] glib: enforce the minimum required version and warn about old APIs, (continued)
- [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Daniel P . Berrangé, 2018/06/06
- Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Philippe Mathieu-Daudé, 2018/06/06
- Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Peter Maydell, 2018/06/06
- Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Peter Xu, 2018/06/06
- Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Markus Armbruster, 2018/06/07
- Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Peter Xu, 2018/06/07
- Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Daniel P . Berrangé, 2018/06/07
- Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Peter Xu, 2018/06/07
Re: [Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h,
Thomas Huth <=
Re: [Qemu-devel] [PATCH v2 0/3] glib: update the min required version, Peter Maydell, 2018/06/08