[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 0/2] memory: fix alignment checks/asserts
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v1 0/2] memory: fix alignment checks/asserts |
Date: |
Fri, 8 Jun 2018 01:01:22 +0300 |
On Thu, Jun 07, 2018 at 05:47:03PM +0200, David Hildenbrand wrote:
> We can currently hit two asserts. Let's fix those.
>
> Patch nr. 1 is a result from:
> "[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers"
>
> We treat right now any alignment > 1GB as a violation, as it would
> fragment guest memory heavily. Turn the assert into a check.
>
> Also, we run into an assert when using alignments that are not a power of
> two.
Reviewed-by: Michael S. Tsirkin <address@hidden>
> David Hildenbrand (2):
> memory-device: turn alignment assert into check
> exec: check that alignment is a power of two
>
> exec.c | 4 ++++
> hw/mem/memory-device.c | 8 +++++++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> --
> 2.17.0