[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type |
Date: |
Fri, 8 Jun 2018 14:31:46 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Fri, Jun 08, 2018 at 11:55:09AM +0800, Peter Xu wrote:
> Instead, use a dynamic function to detect which clock we'll use. The
> problem is that the old code will let monitor initialization depend on
> configure_accelerator() (that's where qtest_enabled() start to take
> effect). After this change, we don't have such a dependency any more.
> We just need to make sure configure_accelerator() is called when we
> start to use it. Now it's only used in monitor_qapi_event_queue() and
> monitor_qapi_event_handler(), so we're good.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> monitor.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
With Markus' suggestion:
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v10 0/7] monitor: let Monitor be thread safe, Peter Xu, 2018/06/07
- [Qemu-devel] [PATCH v10 1/7] monitor: rename out_lock to mon_lock, Peter Xu, 2018/06/07
- [Qemu-devel] [PATCH v10 2/7] monitor: protect mon->fds with mon_lock, Peter Xu, 2018/06/07
- [Qemu-devel] [PATCH v10 3/7] monitor: more comments on lock-free elements, Peter Xu, 2018/06/07
- [Qemu-devel] [PATCH v10 4/7] monitor: fix comment for monitor_lock, Peter Xu, 2018/06/07
- [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type, Peter Xu, 2018/06/07
- Re: [Qemu-devel] [PATCH v10 5/7] monitor: remove event_clock_type,
Stefan Hajnoczi <=
[Qemu-devel] [PATCH v10 6/7] monitor: move init global earlier, Peter Xu, 2018/06/07
[Qemu-devel] [PATCH v10 7/7] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/06/07